Skip to content

Fix test_rule.py error#5

Merged
jertel merged 1 commit intojertel:altfrom
nsano-rururu:fix_test_rule_error
Jan 12, 2021
Merged

Fix test_rule.py error#5
jertel merged 1 commit intojertel:altfrom
nsano-rururu:fix_test_rule_error

Conversation

@nsano-rururu
Copy link
Collaborator

@nsano-rururu nsano-rururu commented Jan 11, 2021 •
edited
Loading

elasticsearch-py Test Run Send real alerts
7.0.0 〇 〇
7.10.0 ✖ ✖
7.10.0 〇
(fix test_rules.py )		 ✖
7.10.0 〇
(fix test_rules.py )		 〇
(Fix initializing self.thread_data.alerts_sent for running elastalert-test-rule #2991)

@jertel jertel merged commit 7a69cd9 into jertel:alt Jan 12, 2021
@jertel
Copy link
Owner

jertel commented Jan 12, 2021

Confirmed that the PR improves the usage of the ES API based on the ES 7.10 documentation located here: https://elasticsearch-py.readthedocs.io/en/v7.10.1/api.html#elasticsearch

@nsano-rururu
Copy link
Collaborator Author

nsano-rururu commented Jan 12, 2021 •
edited
Loading

I've seen the following warning when running ElastAlertServer on Elasticsearch-py 7.10.0: It seems that the new version of Elasticsearch-py now warns you of what will be deprecated in the next major version.

I'm a co-maintainer of https://github.com/johnsusek/praeco and https://github.com/johnsusek/elastalert-serverr, so I installed it in ElastAlert Server in my local environment and tested it.

16:13:49.571Z ERROR elastalert-server:
    ProcessController:  /home/node/.local/lib/python3.8/site-packages/elasticsearch/connection/base.py:190: ElasticsearchDeprecationWarning: Camel case format name dateOptionalTime is deprecated and will be removed in a future version. Use snake case name date_optional_time instead.
      warnings.warn(message, category=ElasticsearchDeprecationWarning)
    /home/node/.local/lib/python3.8/site-packages/elasticsearch/connection/base.py:190: ElasticsearchDeprecationWarning: [types removal] Using include_type_name in put mapping requests is deprecated. The parameter will be removed in the next major version.
      warnings.warn(message, category=ElasticsearchDeprecationWarning)

@nsano-rururu nsano-rururu deleted the fix_test_rule_error branch February 3, 2021 23:17
@nsano-rururu nsano-rururu restored the fix_test_rule_error branch February 4, 2021 02:20
@nsano-rururu nsano-rururu deleted the fix_test_rule_error branch April 25, 2021 02:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nsano-rururu @jertel